From 0585a83103b548f64ac2a9947557dce465cfa57e Mon Sep 17 00:00:00 2001
From: Nir Soffer <nsoffer@redhat.com>
Date: Sat, 18 May 2024 17:42:02 +0300
Subject: [PATCH] Remove fully inactivated linters
Currently golangci-lint fails with these errors:
ERRO [linters_context] golint: This linter is fully inactivated: it will not produce any reports.
ERRO [linters_context] interfacer: This linter is fully inactivated: it will not produce any reports.
ERRO [linters_context] maligned: This linter is fully inactivated: it will not produce any reports.
I could not find any docs explaining what "fully inactivated" mean, but
based this PR[1] it seems that these linters do nothing now. Removing
the linters fixes this issue without changing linting, as they did not
produce any report.
Looking in the linters docs[2] I did not find a replacement for
"interfacer" and "malinged" linters. "stylecheck" seems to be a
replacement for "golint", but we need to fix the code to enable it.
[1] https://github.com/golangci/golangci-lint/pull/4436
[2] https://golangci-lint.run/usage/linters/
---
.golangci.yml | 3 ---
1 file changed, 3 deletions(-)
diff --git a/.golangci.yml b/.golangci.yml
index 22ae622e..2c3562ac 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -33,16 +33,13 @@ linters:
#- gocyclo
#- gofmt
- goimports
- - golint
#- gomnd
#- goprintffuncname
#- gosec
- gosimple
- govet
- ineffassign
- - interfacer
#- lll
- - maligned
- megacheck
#- misspell
#- nakedret