From 45cac892e43fe3a8674a878aaac18612f7a58235 Mon Sep 17 00:00:00 2001 From: aarzilli Date: Fri, 6 Dec 2024 16:38:53 +0100 Subject: [PATCH] make string "help" a constant --- command.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/command.go b/command.go index 7216f1c..ba0e842 100644 --- a/command.go +++ b/command.go @@ -33,6 +33,8 @@ import ( const ( FlagSetByCobraAnnotation = "cobra_annotation_flag_set_by_cobra" CommandDisplayNameAnnotation = "cobra_annotation_command_display_name" + + helpFlagName = "help" ) // FParseErrWhitelist configures Flag parse errors to be ignored @@ -1168,7 +1170,7 @@ func (c *Command) checkCommandGroups() { // If c already has help flag, it will do nothing. func (c *Command) InitDefaultHelpFlag() { c.mergePersistentFlags() - if c.Flags().Lookup("help") == nil { + if c.Flags().Lookup(helpFlagName) == nil { usage := "help for " name := c.DisplayName() if name == "" { @@ -1176,8 +1178,8 @@ func (c *Command) InitDefaultHelpFlag() { } else { usage += name } - c.Flags().BoolP("help", "h", false, usage) - _ = c.Flags().SetAnnotation("help", FlagSetByCobraAnnotation, []string{"true"}) + c.Flags().BoolP(helpFlagName, "h", false, usage) + _ = c.Flags().SetAnnotation(helpFlagName, FlagSetByCobraAnnotation, []string{"true"}) } }