mirror of
https://github.com/spf13/cobra
synced 2024-11-05 21:37:14 +00:00
perf(bash-v2): read directly to COMPREPLY on descriptionless short circuit (#1700)
Not that it'd really matter that much performancewise given the level we are at for this case, but this change makes the short circuit roughly twice as fast on my box as it was for the 1000 rounds done in marckhouzam/cobra-completion-testing. Perhaps more importantly, this makes the code arguably slightly cleaner.
This commit is contained in:
parent
ffa8860dbe
commit
5b11656e45
1 changed files with 1 additions and 3 deletions
|
@ -178,9 +178,7 @@ __%[1]s_handle_standard_completion_case() {
|
|||
|
||||
# Short circuit to optimize if we don't have descriptions
|
||||
if [[ $out != *$tab* ]]; then
|
||||
while IFS='' read -r comp; do
|
||||
COMPREPLY+=("$comp")
|
||||
done < <(IFS=$'\n' compgen -W "$out" -- "$cur")
|
||||
IFS=$'\n' read -ra COMPREPLY -d '' < <(IFS=$'\n' compgen -W "$out" -- "$cur")
|
||||
return 0
|
||||
fi
|
||||
|
||||
|
|
Loading…
Reference in a new issue