mirror of
https://github.com/spf13/cobra
synced 2024-11-24 14:47:12 +00:00
Fix reproducibility in TestGolden{Add,Init}Cmd
These tests were time-dependent and would start failing in 2018 when the golden files still have the copyright year of 2017. Fix by hard-coding the year 2017 for the purpose of these two tests to ensure reproducible builds. Fixes #503
This commit is contained in:
parent
161584fc2e
commit
750ba8ac93
3 changed files with 15 additions and 1 deletions
|
@ -6,6 +6,8 @@ import (
|
||||||
"os"
|
"os"
|
||||||
"path/filepath"
|
"path/filepath"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
|
"github.com/spf13/viper"
|
||||||
)
|
)
|
||||||
|
|
||||||
// TestGoldenAddCmd initializes the project "github.com/spf13/testproject"
|
// TestGoldenAddCmd initializes the project "github.com/spf13/testproject"
|
||||||
|
@ -20,6 +22,9 @@ func TestGoldenAddCmd(t *testing.T) {
|
||||||
// Initialize the project at first.
|
// Initialize the project at first.
|
||||||
initializeProject(project)
|
initializeProject(project)
|
||||||
defer os.RemoveAll(project.AbsPath())
|
defer os.RemoveAll(project.AbsPath())
|
||||||
|
defer viper.Set("year", nil)
|
||||||
|
|
||||||
|
viper.Set("year", 2017) // For reproducible builds
|
||||||
|
|
||||||
// Then add the "test" command.
|
// Then add the "test" command.
|
||||||
cmdName := "test"
|
cmdName := "test"
|
||||||
|
|
|
@ -6,6 +6,8 @@ import (
|
||||||
"os"
|
"os"
|
||||||
"path/filepath"
|
"path/filepath"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
|
"github.com/spf13/viper"
|
||||||
)
|
)
|
||||||
|
|
||||||
// TestGoldenInitCmd initializes the project "github.com/spf13/testproject"
|
// TestGoldenInitCmd initializes the project "github.com/spf13/testproject"
|
||||||
|
@ -16,6 +18,9 @@ func TestGoldenInitCmd(t *testing.T) {
|
||||||
projectName := "github.com/spf13/testproject"
|
projectName := "github.com/spf13/testproject"
|
||||||
project := NewProject(projectName)
|
project := NewProject(projectName)
|
||||||
defer os.RemoveAll(project.AbsPath())
|
defer os.RemoveAll(project.AbsPath())
|
||||||
|
defer viper.Set("year", nil)
|
||||||
|
|
||||||
|
viper.Set("year", 2017) // For reproducible builds
|
||||||
|
|
||||||
os.Args = []string{"cobra", "init", projectName}
|
os.Args = []string{"cobra", "init", projectName}
|
||||||
if err := rootCmd.Execute(); err != nil {
|
if err := rootCmd.Execute(); err != nil {
|
||||||
|
|
|
@ -77,7 +77,11 @@ func getLicense() License {
|
||||||
|
|
||||||
func copyrightLine() string {
|
func copyrightLine() string {
|
||||||
author := viper.GetString("author")
|
author := viper.GetString("author")
|
||||||
year := time.Now().Format("2006")
|
|
||||||
|
year := viper.GetString("year") // For reproducible builds
|
||||||
|
if year == "" {
|
||||||
|
year = time.Now().Format("2006")
|
||||||
|
}
|
||||||
|
|
||||||
return "Copyright © " + year + " " + author
|
return "Copyright © " + year + " " + author
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue