glenux-archive/spf13--cobra
1
0
Fork 0
mirror of https://github.com/spf13/cobra synced 2025-01-30 15:36:47 +00:00
Code Issues Projects Releases Packages Wiki Activity

Removing unused includeDesc parameter

Browse source
This commit is contained in:
Jack Wright 2024-12-29 13:23:29 -08:00
parent 997ac04e61
commit ae37156f63
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
completions.go
View file

@ -868,7 +868,7 @@ https://www.nushell.sh/cookbook/external_completers.html#multiple-completer
Args: NoArgs, Args: NoArgs,
ValidArgsFunction: NoFileCompletions, ValidArgsFunction: NoFileCompletions,
RunE: func(cmd *Command, args []string) error { RunE: func(cmd *Command, args []string) error {
return cmd.Root().GenNushellCompletion(out, !noDesc) return cmd.Root().GenNushellCompletion(out)
}, },
} }
if haveNoDescFlag { if haveNoDescFlag {

6
nushell_completions.go
View file

@ -21,7 +21,7 @@ import (
"os" "os"
) )
func (c *Command) GenNushellCompletion(w io.Writer, includeDesc bool) error { func (c *Command) GenNushellCompletion(w io.Writer) error {
buf := new(bytes.Buffer) buf := new(bytes.Buffer)
WriteStringAndCheck(buf, "# nushell completion -*- shell-script -*- \n") WriteStringAndCheck(buf, "# nushell completion -*- shell-script -*- \n")
WriteStringAndCheck(buf, fmt.Sprintf(` WriteStringAndCheck(buf, fmt.Sprintf(`
@ -120,12 +120,12 @@ let cobra_completer = {|spans|
return err return err
} }
func (c *Command) GenNushellCompletionFile(filename string, includeDesc bool) error { func (c *Command) GenNushellCompletionFile(filename string) error {
outFile, err := os.Create(filename) outFile, err := os.Create(filename)
if err != nil { if err != nil {
return err return err
} }
defer outFile.Close() defer outFile.Close()
return c.GenNushellCompletion(outFile, includeDesc) return c.GenNushellCompletion(outFile)
} }

8
nushell_completions_test.go
View file

@ -38,7 +38,7 @@ func TestGenNushellCompletion(t *testing.T) {
rootCmd.AddCommand(getCmd) rootCmd.AddCommand(getCmd)
buf := new(bytes.Buffer) buf := new(bytes.Buffer)
assertNoErr(t, rootCmd.GenNushellCompletion(buf, true)) assertNoErr(t, rootCmd.GenNushellCompletion(buf))
} }
func TestGenNushellCompletionFile(t *testing.T) { func TestGenNushellCompletionFile(t *testing.T) {
@ -57,7 +57,7 @@ func TestGenNushellCompletionFile(t *testing.T) {
} }
rootCmd.AddCommand(child) rootCmd.AddCommand(child)
assertNoErr(t, rootCmd.GenNushellCompletionFile(tmpFile.Name(), true)) assertNoErr(t, rootCmd.GenNushellCompletionFile(tmpFile.Name()))
} }
func TestFailGenNushellCompletionFile(t *testing.T) { func TestFailGenNushellCompletionFile(t *testing.T) {
@ -79,7 +79,7 @@ func TestFailGenNushellCompletionFile(t *testing.T) {
} }
rootCmd.AddCommand(child) rootCmd.AddCommand(child)
got := rootCmd.GenNushellCompletionFile(f.Name(), false) got := rootCmd.GenNushellCompletionFile(f.Name())
if !errors.Is(got, os.ErrPermission) { if !errors.Is(got, os.ErrPermission) {
t.Errorf("got: %s, want: %s", got.Error(), os.ErrPermission.Error()) t.Errorf("got: %s, want: %s", got.Error(), os.ErrPermission.Error())
} }
@ -89,7 +89,7 @@ func TestNushellCompletionNoActiveHelp(t *testing.T) {
c := &Command{Use: "c", Run: emptyRun} c := &Command{Use: "c", Run: emptyRun}
buf := new(bytes.Buffer) buf := new(bytes.Buffer)
assertNoErr(t, c.GenNushellCompletion(buf, true)) assertNoErr(t, c.GenNushellCompletion(buf))
output := buf.String() output := buf.String()
// check that active help is being disabled // check that active help is being disabled