glenux-archive/spf13--cobra
1
0
Fork 0
mirror of https://github.com/spf13/cobra synced 2024-06-28 22:59:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd: Fix some gometalinter complaints

Browse source
This commit is contained in:
Albert Nigmatzianov 2017-05-14 12:27:15 +02:00
parent d9414968f8
commit b5366273a6
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cobra/cmd/helpers.go
View file

@ -23,8 +23,6 @@ import (
"text/template" "text/template"
) )
var projectPath string
var cmdDirs = [...]string{"cmd", "cmds", "command", "commands"} var cmdDirs = [...]string{"cmd", "cmds", "command", "commands"}
var srcPaths []string var srcPaths []string

4
cobra/cmd/init_test.go
View file

@ -54,7 +54,9 @@ func TestGoldenInitCmd(t *testing.T) {
if err != nil { if err != nil {
return err return err
} }
ioutil.WriteFile(goldenPath, got, 0644) if err := ioutil.WriteFile(goldenPath, got, 0644); err != nil {
t.Fatal("Error while updating file:", err)
}
} }
return compareFiles(path, goldenPath) return compareFiles(path, goldenPath)
} }

2
cobra/cmd/project.go
View file

@ -37,7 +37,7 @@ func NewProject(projectName string) *Project {
} }
for _, srcPath := range srcPaths { for _, srcPath := range srcPaths {
goPath := filepath.Dir(srcPath) goPath := filepath.Dir(srcPath)
if filepath.HasPrefix(wd, goPath) { if strings.HasPrefix(wd, goPath) {
p.absPath = filepath.Join(srcPath, projectName) p.absPath = filepath.Join(srcPath, projectName)
break break
} }

4
cobra/cmd/project_test.go
View file

@ -1,7 +1,7 @@
package cmd package cmd
import ( import (
"path/filepath" "strings"
"testing" "testing"
) )
@ -17,7 +17,7 @@ func TestFindExistingPackage(t *testing.T) {
func hasGoPathPrefix(path string) bool { func hasGoPathPrefix(path string) bool {
for _, srcPath := range srcPaths { for _, srcPath := range srcPaths {
if filepath.HasPrefix(path, srcPath) { if strings.HasPrefix(path, srcPath) {
return true return true
} }
} }