glenux-archive/spf13--cobra
1
0
Fork 0
mirror of https://github.com/spf13/cobra synced 2024-09-28 19:06:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

In execute(), check if command is Runnable()

Browse source 
A corner case exists where c.Runnable() is not checked
before c.Run() is called, thus a nil c.Run is executed
leading to "panic: runtime error: invalid memory address
or nil pointer dereference".

This patch adds an extra c.Runnable() check in execute()
to catch that corner case.

Fixes #37.
This commit is contained in:
Anthony Fok 2014-12-11 10:06:11 -07:00
parent b825817fc0
commit f7825f4104
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
command.go
View file

@ -357,8 +357,9 @@ func (c *Command) execute(a []string) (err error) {
if err != nil { if err != nil {
return err return err
} else { } else {
// If help is called, regardless of other flags, we print that // If help is called, regardless of other flags, we print that.
if c.helpFlagVal { // Print help also if c.Run is nil.
if c.helpFlagVal || !c.Runnable() {
c.Help() c.Help()
return nil return nil
} }