Add breaking test that requires reverting #673

This commit is contained in:
Mark Sagi-Kazar 2019-09-27 17:09:18 +02:00 committed by Márk Sági-Kazár
parent 371f39c3ab
commit 398adc5a7d

View file

@ -254,7 +254,7 @@ func initDirs(t *testing.T) (string, string, func()) {
} }
} }
//stubs for PFlag Values // stubs for PFlag Values
type stringValue string type stringValue string
func newStringValue(val string, p *string) *stringValue { func newStringValue(val string, p *string) *stringValue {
@ -864,7 +864,7 @@ func TestBindPFlag(t *testing.T) {
assert.Equal(t, testString, Get("testvalue")) assert.Equal(t, testString, Get("testvalue"))
flag.Value.Set("testing_mutate") flag.Value.Set("testing_mutate")
flag.Changed = true //hack for pflag usage flag.Changed = true // hack for pflag usage
assert.Equal(t, "testing_mutate", Get("testvalue")) assert.Equal(t, "testing_mutate", Get("testvalue"))
@ -1856,6 +1856,23 @@ func TestWatchFile(t *testing.T) {
} }
func TestUnmarshal_DotSeparatorBackwardCompatibility(t *testing.T) {
flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
flags.String("foo.bar", "cobra_flag", "")
v := New()
assert.NoError(t, v.BindPFlags(flags))
config := &struct {
Foo struct {
Bar string
}
}{}
assert.NoError(t, v.Unmarshal(config))
assert.Equal(t, "cobra_flag", config.Foo.Bar)
}
func BenchmarkGetBool(b *testing.B) { func BenchmarkGetBool(b *testing.B) {
key := "BenchmarkGetBool" key := "BenchmarkGetBool"
v = New() v = New()