From 3dca0c3bbf0a0de516c453a58f89289795be41cc Mon Sep 17 00:00:00 2001
From: Mark Fine <mfine@roblox.com>
Date: Wed, 5 Jul 2023 13:25:44 -0700
Subject: [PATCH] Add tests, expand name.

---
 viper.go      |  6 +++---
 viper_test.go | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 51 insertions(+), 3 deletions(-)

diff --git a/viper.go b/viper.go
index e124790..0f5cb60 100644
--- a/viper.go
+++ b/viper.go
@@ -1478,11 +1478,11 @@ func (v *Viper) SetEnvKeyReplacer(r *strings.Replacer) {
 	v.envKeyReplacer = r
 }
 
-// SetKeyDelim sets the delimiter used for determining key parts on the viper
+// SetKeyDelimiter sets the delimiter used for determining key parts on the viper
 // object.
-func SetKeyDelim(d string) { v.SetKeyDelim(d) }
+func SetKeyDelimiter(d string) { v.SetKeyDelimiter(d) }
 
-func (v *Viper) SetKeyDelim(d string) {
+func (v *Viper) SetKeyDelimiter(d string) {
 	v.keyDelim = d
 }
 
diff --git a/viper_test.go b/viper_test.go
index e0bfc57..d7bb604 100644
--- a/viper_test.go
+++ b/viper_test.go
@@ -2629,6 +2629,54 @@ func TestKeyDelimiter(t *testing.T) {
 	assert.Equal(t, expected, actual)
 }
 
+func TestSetKeyDelimiter(t *testing.T) {
+	v := New()
+	v.SetKeyDelimiter("::")
+	v.SetConfigType("yaml")
+	r := strings.NewReader(string(yamlExampleWithDot))
+
+	err := v.unmarshalReader(r, v.config)
+	require.NoError(t, err)
+
+	values := map[string]interface{}{
+		"image": map[string]interface{}{
+			"repository": "someImage",
+			"tag":        "1.0.0",
+		},
+		"ingress": map[string]interface{}{
+			"annotations": map[string]interface{}{
+				"traefik.frontend.rule.type":                 "PathPrefix",
+				"traefik.ingress.kubernetes.io/ssl-redirect": "true",
+			},
+		},
+	}
+
+	v.SetDefault("charts::values", values)
+
+	assert.Equal(t, "leather", v.GetString("clothing::jacket"))
+	assert.Equal(t, "01/02/03", v.GetString("emails::steve@hacker.com::created"))
+
+	type config struct {
+		Charts struct {
+			Values map[string]interface{}
+		}
+	}
+
+	expected := config{
+		Charts: struct {
+			Values map[string]interface{}
+		}{
+			Values: values,
+		},
+	}
+
+	var actual config
+
+	assert.NoError(t, v.Unmarshal(&actual))
+
+	assert.Equal(t, expected, actual)
+}
+
 var yamlDeepNestedSlices = []byte(`TV:
 - title: "The Expanse"
   title_i18n: