glenux-archive/spf13--viper
1
0
Fork 0
mirror of https://github.com/spf13/viper synced 2024-11-04 20:27:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

Updated TestBindPFlagsStringSlice() to highlight a failure

Browse source 
When pflag marked as changed, the value is not detected
(and lower priority value used)
This commit is contained in:
Benoit Masson 2017-04-17 18:33:30 +02:00 committed by Bjørn Erik Pedersen
parent b7a3b95476
commit cc7e906d88
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
viper_test.go
View file

@ -613,6 +613,8 @@ func TestBindPFlags(t *testing.T) {
} }
func TestBindPFlagsStringSlice(t *testing.T) { func TestBindPFlagsStringSlice(t *testing.T) {
defaultVal := []string{"default"}
for _, testValue := range []struct { for _, testValue := range []struct {
Expected []string Expected []string
Value string Value string
@ -624,6 +626,8 @@ func TestBindPFlagsStringSlice(t *testing.T) {
for _, changed := range []bool{true, false} { for _, changed := range []bool{true, false} {
v := New() // create independent Viper object v := New() // create independent Viper object
v.SetDefault("stringslice", defaultVal)
flagSet := pflag.NewFlagSet("test", pflag.ContinueOnError) flagSet := pflag.NewFlagSet("test", pflag.ContinueOnError)
flagSet.StringSlice("stringslice", testValue.Expected, "test") flagSet.StringSlice("stringslice", testValue.Expected, "test")
flagSet.Visit(func(f *pflag.Flag) { flagSet.Visit(func(f *pflag.Flag) {
@ -645,7 +649,11 @@ func TestBindPFlagsStringSlice(t *testing.T) {
if err := v.Unmarshal(val); err != nil { if err := v.Unmarshal(val); err != nil {
t.Fatalf("%+#v cannot unmarshal: %s", testValue.Value, err) t.Fatalf("%+#v cannot unmarshal: %s", testValue.Value, err)
} }
if changed {
assert.Equal(t, testValue.Expected, val.StringSlice) assert.Equal(t, testValue.Expected, val.StringSlice)
} else {
assert.Equal(t, defaultVal, val.StringSlice)
}
} }
} }
} }