diff --git a/.example-env b/.example-env index 96b60f55..03f7f615 100644 --- a/.example-env +++ b/.example-env @@ -6,7 +6,7 @@ export DB_USERNAME='postgres' export DB_PASSWORD='3112' export DB_HOST='localhost' export DB_PORT='5432' -export DB_NAME='metamap002' +export DB_NAME='metamaps' export REALTIME_SERVER='http://localhost:5000' export MAILER_DEFAULT_URL='localhost:3000' diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index dddeed14..21d9cbfb 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,4 +1,12 @@ +please link to related trello cards, if they exist, from the following two boards respectively +https://trello.com/b/8HlCikOX/metamaps-design + +https://trello.com/b/uFOA6a2x/metamaps-feedback-feature-ideas-requests + +[the issue as framed for design]() + +[the issue as framed from the users perspective]() ============ diff --git a/.rubocop.yml b/.rubocop.yml index 6bdcbfc3..e7819c17 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -19,3 +19,6 @@ Metrics/AbcSize: Style/Documentation: Enabled: false + +Style/EmptyMethod: + EnforcedStyle: expanded diff --git a/Gemfile b/Gemfile index 56ee0bd2..cf3eecb1 100644 --- a/Gemfile +++ b/Gemfile @@ -9,7 +9,6 @@ gem 'aws-sdk' gem 'best_in_place' gem 'delayed_job' gem 'delayed_job_active_record' -gem 'sucker_punch' gem 'devise' gem 'doorkeeper' gem 'dotenv-rails' @@ -20,6 +19,7 @@ gem 'kaminari' gem 'mailboxer' gem 'paperclip' gem 'pg' +gem 'puma' gem 'pundit' gem 'pundit_extra' gem 'rack-attack' @@ -27,7 +27,7 @@ gem 'rack-cors' gem 'redis' gem 'slack-notifier' gem 'snorlax' -gem 'puma' +gem 'sucker_punch' # asset stuff gem 'jquery-rails' @@ -36,12 +36,12 @@ gem 'sass-rails' gem 'uglifier' group :test do + gem 'brakeman', require: false gem 'factory_girl_rails' gem 'json-schema' gem 'rspec-rails' gem 'shoulda-matchers' gem 'simplecov', require: false - gem 'brakeman', require: false end group :development, :test do @@ -49,6 +49,6 @@ group :development, :test do gem 'binding_of_caller' gem 'pry-byebug' gem 'pry-rails' - gem 'tunemygc' gem 'rubocop' + gem 'tunemygc' end diff --git a/Gemfile.lock b/Gemfile.lock index 2397c647..fd414eb2 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,57 +1,60 @@ GEM remote: https://rubygems.org/ specs: - actioncable (5.0.0.1) - actionpack (= 5.0.0.1) + actioncable (5.0.1) + actionpack (= 5.0.1) nio4r (~> 1.2) websocket-driver (~> 0.6.1) - actionmailer (5.0.0.1) - actionpack (= 5.0.0.1) - actionview (= 5.0.0.1) - activejob (= 5.0.0.1) + actionmailer (5.0.1) + actionpack (= 5.0.1) + actionview (= 5.0.1) + activejob (= 5.0.1) mail (~> 2.5, >= 2.5.4) rails-dom-testing (~> 2.0) - actionpack (5.0.0.1) - actionview (= 5.0.0.1) - activesupport (= 5.0.0.1) + actionpack (5.0.1) + actionview (= 5.0.1) + activesupport (= 5.0.1) rack (~> 2.0) rack-test (~> 0.6.3) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.0.2) - actionview (5.0.0.1) - activesupport (= 5.0.0.1) + actionview (5.0.1) + activesupport (= 5.0.1) builder (~> 3.1) erubis (~> 2.7.0) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.0.2) - active_model_serializers (0.10.2) + active_model_serializers (0.10.4) actionpack (>= 4.1, < 6) activemodel (>= 4.1, < 6) - jsonapi (~> 0.1.1.beta2) - railties (>= 4.1, < 6) - activejob (5.0.0.1) - activesupport (= 5.0.0.1) + case_transform (>= 0.2) + jsonapi (= 0.1.1.beta6) + activejob (5.0.1) + activesupport (= 5.0.1) globalid (>= 0.3.6) - activemodel (5.0.0.1) - activesupport (= 5.0.0.1) - activerecord (5.0.0.1) - activemodel (= 5.0.0.1) - activesupport (= 5.0.0.1) + activemodel (5.0.1) + activesupport (= 5.0.1) + activerecord (5.0.1) + activemodel (= 5.0.1) + activesupport (= 5.0.1) arel (~> 7.0) - activesupport (5.0.0.1) + activesupport (5.0.1) concurrent-ruby (~> 1.0, >= 1.0.2) i18n (~> 0.7) minitest (~> 5.1) tzinfo (~> 1.1) - addressable (2.3.8) - arel (7.1.2) + addressable (2.5.0) + public_suffix (~> 2.0, >= 2.0.2) + arel (7.1.4) ast (2.3.0) - aws-sdk (2.6.3) - aws-sdk-resources (= 2.6.3) - aws-sdk-core (2.6.3) + aws-sdk (2.7.0) + aws-sdk-resources (= 2.7.0) + aws-sdk-core (2.7.0) + aws-sigv4 (~> 1.0) jmespath (~> 1.0) - aws-sdk-resources (2.6.3) - aws-sdk-core (= 2.6.3) + aws-sdk-resources (2.7.0) + aws-sdk-core (= 2.7.0) + aws-sigv4 (1.0.0) bcrypt (3.1.11) best_in_place (3.1.0) actionpack (>= 3.2) @@ -62,21 +65,20 @@ GEM rack (>= 0.9.0) binding_of_caller (0.7.2) debug_inspector (>= 0.0.1) - brakeman (3.4.0) - builder (3.2.2) - byebug (9.0.5) - carrierwave (0.11.2) - activemodel (>= 3.2.0) - activesupport (>= 3.2.0) - json (>= 1.7) + brakeman (3.4.1) + builder (3.2.3) + byebug (9.0.6) + carrierwave (1.0.0) + activemodel (>= 4.0.0) + activesupport (>= 4.0.0) mime-types (>= 1.16) - mimemagic (>= 0.3.0) - climate_control (0.0.3) - activesupport (>= 3.0) + case_transform (0.2) + activesupport + climate_control (0.1.0) cocaine (0.5.8) climate_control (>= 0.0.3, < 1.0) coderay (1.1.1) - concurrent-ruby (1.0.2) + concurrent-ruby (1.0.4) debug_inspector (0.0.2) delayed_job (4.1.2) activesupport (>= 3.0, < 5.1) @@ -89,23 +91,23 @@ GEM railties (>= 4.1.0, < 5.1) responders warden (~> 1.2.3) - diff-lcs (1.2.5) + diff-lcs (1.3) docile (1.1.5) doorkeeper (4.2.0) railties (>= 4.2) - dotenv (2.1.1) - dotenv-rails (2.1.1) - dotenv (= 2.1.1) - railties (>= 4.0, < 5.1) + dotenv (2.1.2) + dotenv-rails (2.1.2) + dotenv (= 2.1.2) + railties (>= 3.2, < 5.1) erubis (2.7.0) exception_notification (4.2.1) actionmailer (>= 4.0, < 6) activesupport (>= 4.0, < 6) execjs (2.7.0) - factory_girl (4.7.0) + factory_girl (4.8.0) activesupport (>= 3.0.0) - factory_girl_rails (4.7.0) - factory_girl (~> 4.7.0) + factory_girl_rails (4.8.0) + factory_girl (~> 4.8.0) railties (>= 3.0.0) globalid (0.3.7) activesupport (>= 4.1.0) @@ -113,20 +115,32 @@ GEM multi_xml (>= 0.5.2) i18n (0.7.0) jmespath (1.3.1) - jquery-rails (4.2.1) + jquery-rails (4.2.2) rails-dom-testing (>= 1, < 3) railties (>= 4.2.0) thor (>= 0.14, < 2.0) - jquery-ui-rails (5.0.5) + jquery-ui-rails (6.0.1) railties (>= 3.2.16) - json (1.8.3) - json-schema (2.6.2) - addressable (~> 2.3.8) - jsonapi (0.1.1.beta2) - json (~> 1.8) - kaminari (0.17.0) - actionpack (>= 3.0.0) - activesupport (>= 3.0.0) + json (2.0.3) + json-schema (2.7.0) + addressable (>= 2.4) + jsonapi (0.1.1.beta6) + jsonapi-parser (= 0.1.1.beta3) + jsonapi-renderer (= 0.1.1.beta1) + jsonapi-parser (0.1.1.beta3) + jsonapi-renderer (0.1.1.beta1) + kaminari (1.0.1) + activesupport (>= 4.1.0) + kaminari-actionview (= 1.0.1) + kaminari-activerecord (= 1.0.1) + kaminari-core (= 1.0.1) + kaminari-actionview (1.0.1) + actionview + kaminari-core (= 1.0.1) + kaminari-activerecord (1.0.1) + activerecord + kaminari-core (= 1.0.1) + kaminari-core (1.0.1) loofah (2.0.3) nokogiri (>= 1.5.9) mail (2.6.4) @@ -140,12 +154,11 @@ GEM mime-types-data (3.2016.0521) mimemagic (0.3.2) mini_portile2 (2.1.0) - minitest (5.9.1) - multi_xml (0.5.5) + minitest (5.10.1) + multi_xml (0.6.0) nio4r (1.2.1) - nokogiri (1.6.8) + nokogiri (1.7.0.1) mini_portile2 (~> 2.1.0) - pkg-config (~> 1.1.7) orm_adapter (0.5.0) paperclip (5.1.0) activemodel (>= 4.2.0) @@ -153,20 +166,20 @@ GEM cocaine (~> 0.5.5) mime-types mimemagic (~> 0.3.0) - parser (2.3.1.4) + parser (2.3.3.1) ast (~> 2.2) pg (0.19.0) - pkg-config (1.1.7) powerpack (0.1.1) pry (0.10.4) coderay (~> 1.1.0) method_source (~> 0.8.1) slop (~> 3.4) - pry-byebug (3.4.0) + pry-byebug (3.4.2) byebug (~> 9.0) pry (~> 0.10) pry-rails (0.3.4) pry (>= 0.9.10) + public_suffix (2.0.5) puma (3.6.2) pundit (1.1.0) activesupport (>= 3.0.0) @@ -177,35 +190,35 @@ GEM rack-cors (0.4.0) rack-test (0.6.3) rack (>= 1.0) - rails (5.0.0.1) - actioncable (= 5.0.0.1) - actionmailer (= 5.0.0.1) - actionpack (= 5.0.0.1) - actionview (= 5.0.0.1) - activejob (= 5.0.0.1) - activemodel (= 5.0.0.1) - activerecord (= 5.0.0.1) - activesupport (= 5.0.0.1) + rails (5.0.1) + actioncable (= 5.0.1) + actionmailer (= 5.0.1) + actionpack (= 5.0.1) + actionview (= 5.0.1) + activejob (= 5.0.1) + activemodel (= 5.0.1) + activerecord (= 5.0.1) + activesupport (= 5.0.1) bundler (>= 1.3.0, < 2.0) - railties (= 5.0.0.1) + railties (= 5.0.1) sprockets-rails (>= 2.0.0) - rails-dom-testing (2.0.1) + rails-dom-testing (2.0.2) activesupport (>= 4.2.0, < 6.0) - nokogiri (~> 1.6.0) + nokogiri (~> 1.6) rails-html-sanitizer (1.0.3) loofah (~> 2.0) - railties (5.0.0.1) - actionpack (= 5.0.0.1) - activesupport (= 5.0.0.1) + railties (5.0.1) + actionpack (= 5.0.1) + activesupport (= 5.0.1) method_source rake (>= 0.8.7) thor (>= 0.18.1, < 2.0) - rainbow (2.1.0) - rake (11.3.0) - redis (3.3.1) + rainbow (2.2.1) + rake (12.0.0) + redis (3.3.2) responders (2.3.0) railties (>= 4.2.0, < 5.1) - rspec-core (3.5.3) + rspec-core (3.5.4) rspec-support (~> 3.5.0) rspec-expectations (3.5.0) diff-lcs (>= 1.2.0, < 2.0) @@ -222,14 +235,14 @@ GEM rspec-mocks (~> 3.5.0) rspec-support (~> 3.5.0) rspec-support (3.5.0) - rubocop (0.43.0) - parser (>= 2.3.1.1, < 3.0) + rubocop (0.47.1) + parser (>= 2.3.3.1, < 3.0) powerpack (~> 0.1) rainbow (>= 1.99.1, < 3.0) ruby-progressbar (~> 1.7) unicode-display_width (~> 1.0, >= 1.0.1) ruby-progressbar (1.8.1) - sass (3.4.22) + sass (3.4.23) sass-rails (5.0.6) railties (>= 4.0.0, < 6) sass (~> 3.1) @@ -243,11 +256,11 @@ GEM json (>= 1.8, < 3) simplecov-html (~> 0.10.0) simplecov-html (0.10.0) - slack-notifier (1.5.1) + slack-notifier (2.0.0) slop (3.6.0) snorlax (0.1.6) rails (> 4.1) - sprockets (3.7.0) + sprockets (3.7.1) concurrent-ruby (~> 1.0) rack (> 1, < 3) sprockets-rails (3.2.0) @@ -256,15 +269,15 @@ GEM sprockets (>= 3.0.0) sucker_punch (2.0.2) concurrent-ruby (~> 1.0.0) - thor (0.19.1) + thor (0.19.4) thread_safe (0.3.5) tilt (2.0.5) - tunemygc (1.0.68) + tunemygc (1.0.69) tzinfo (1.2.2) thread_safe (~> 0.1) - uglifier (3.0.2) + uglifier (3.0.4) execjs (>= 0.3.0, < 3) - unicode-display_width (1.1.1) + unicode-display_width (1.1.3) warden (1.2.6) rack (>= 1.0) websocket-driver (0.6.4) @@ -321,4 +334,4 @@ RUBY VERSION ruby 2.3.0p0 BUNDLED WITH - 1.13.6 + 1.13.7 diff --git a/README.md b/README.md index 67159c68..db3cf24e 100644 --- a/README.md +++ b/README.md @@ -2,6 +2,7 @@ Metamaps ======= [![Build Status](https://travis-ci.org/metamaps/metamaps.svg?branch=develop)](https://travis-ci.org/metamaps/metamaps) +[![Code Climate](https://codeclimate.com/github/metamaps/metamaps/badges/gpa.svg)](https://codeclimate.com/github/metamaps/metamaps) ## What is Metamaps? @@ -16,8 +17,14 @@ Metamaps is developed and maintained by a distributed, nomadic community compris - Contact: [team@metamaps.cc](mailto:team@metamaps.cc) or [@metamapps](https://twitter.com/metamapps) on Twitter - User Documentation: [docs.metamaps.cc](https://docs.metamaps.cc) - User Community: [hylo.com/c/metamaps](https://www.hylo.com/c/metamaps) -- Development Roadmap: [github.com/metamaps/metamaps/milestones](https://github.com/metamaps/metamaps/milestones) -- To send us a personal message or request an invite to the open beta, get in touch with us via email, Twitter, or Hylo +- To see what we're developing, or to weigh in on what you'd like to see developed, see our [Metamaps Feedback and Features](https://trello.com/b/uFOA6a2x/metamaps-feedback-feature-ideas-requests) board on trello +- To follow along with, or contribute,to our design process, see our [Metamaps Design](https://trello.com/b/8HlCikOX/metamaps-design) board on trello +- To follow along with, or contribute to, our development process, see our [Github Issues and Pull Requests](https://github.com/metamaps/metamaps/issues) +- Request an invite to the open beta [here](https://metamaps.cc/request) + + + +- To send us a personal message get in touch with us via email, Twitter, or Hylo - If you would like to report a bug, please check the [issues][contributing-issues] section in our [contributing instructions][contributing]. - If you would like to get set up as a developer, that's great! Read on for help getting your development environment set up. diff --git a/app/assets/config/manifest.js b/app/assets/config/manifest.js index 72a7189c..41328039 100644 --- a/app/assets/config/manifest.js +++ b/app/assets/config/manifest.js @@ -1,3 +1,4 @@ +// eslint-disable spaced-comment // JS and CSS bundles //= link_directory ../javascripts .js //= link_directory ../stylesheets .css diff --git a/app/assets/javascripts/application.js b/app/assets/javascripts/application.js index 6af52fbd..55b2c13f 100644 --- a/app/assets/javascripts/application.js +++ b/app/assets/javascripts/application.js @@ -1,4 +1,3 @@ -// eslint-disable spaced-comment // This is a manifest file that'll be compiled into application.js, which will include all the files // listed below. // @@ -10,7 +9,8 @@ // // WARNING: THE FIRST BLANK LINE MARKS THE END OF WHAT'S TO BE PROCESSED, ANY BLANK LINE SHOULD // GO AFTER THE REQUIRES BELOW. -// +// +/* eslint-disable spaced-comment */ //= require jquery //= require jquery-ui //= require jquery_ujs @@ -19,3 +19,4 @@ //= require ./webpacked/metamaps.bundle //= require ./Metamaps.ServerData //= require homepageVimeoFallback +/* eslint-enable spaced-comment */ diff --git a/app/assets/javascripts/homepageVimeoFallback.js b/app/assets/javascripts/homepageVimeoFallback.js index e4f5a67a..53c691eb 100644 --- a/app/assets/javascripts/homepageVimeoFallback.js +++ b/app/assets/javascripts/homepageVimeoFallback.js @@ -1,11 +1,11 @@ /* global $ */ -$(document).ready(function () { +$(document).ready(function() { if (window.location.pathname === '/') { $.ajax({ type: 'GET', url: 'https://player.vimeo.com', - error: function (e) { + error: function(e) { $('.homeVideo').hide() $('.homeVideo').replaceWith($('