diff --git a/.rubocop.yml b/.rubocop.yml index 6bdcbfc3..e7819c17 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -19,3 +19,6 @@ Metrics/AbcSize: Style/Documentation: Enabled: false + +Style/EmptyMethod: + EnforcedStyle: expanded diff --git a/Gemfile b/Gemfile index 56ee0bd2..cf3eecb1 100644 --- a/Gemfile +++ b/Gemfile @@ -9,7 +9,6 @@ gem 'aws-sdk' gem 'best_in_place' gem 'delayed_job' gem 'delayed_job_active_record' -gem 'sucker_punch' gem 'devise' gem 'doorkeeper' gem 'dotenv-rails' @@ -20,6 +19,7 @@ gem 'kaminari' gem 'mailboxer' gem 'paperclip' gem 'pg' +gem 'puma' gem 'pundit' gem 'pundit_extra' gem 'rack-attack' @@ -27,7 +27,7 @@ gem 'rack-cors' gem 'redis' gem 'slack-notifier' gem 'snorlax' -gem 'puma' +gem 'sucker_punch' # asset stuff gem 'jquery-rails' @@ -36,12 +36,12 @@ gem 'sass-rails' gem 'uglifier' group :test do + gem 'brakeman', require: false gem 'factory_girl_rails' gem 'json-schema' gem 'rspec-rails' gem 'shoulda-matchers' gem 'simplecov', require: false - gem 'brakeman', require: false end group :development, :test do @@ -49,6 +49,6 @@ group :development, :test do gem 'binding_of_caller' gem 'pry-byebug' gem 'pry-rails' - gem 'tunemygc' gem 'rubocop' + gem 'tunemygc' end diff --git a/app/assets/config/manifest.js b/app/assets/config/manifest.js index 72a7189c..41328039 100644 --- a/app/assets/config/manifest.js +++ b/app/assets/config/manifest.js @@ -1,3 +1,4 @@ +// eslint-disable spaced-comment // JS and CSS bundles //= link_directory ../javascripts .js //= link_directory ../stylesheets .css diff --git a/app/assets/javascripts/application.js b/app/assets/javascripts/application.js index 4483452c..529ab13e 100644 --- a/app/assets/javascripts/application.js +++ b/app/assets/javascripts/application.js @@ -1,4 +1,3 @@ -// eslint-disable spaced-comment // This is a manifest file that'll be compiled into application.js, which will include all the files // listed below. // @@ -10,7 +9,8 @@ // // WARNING: THE FIRST BLANK LINE MARKS THE END OF WHAT'S TO BE PROCESSED, ANY BLANK LINE SHOULD // GO AFTER THE REQUIRES BELOW. -// +// +/* eslint-disable spaced-comment */ //= require jquery3 //= require jquery-ui //= require jquery_ujs @@ -19,3 +19,4 @@ //= require ./webpacked/metamaps.bundle //= require ./Metamaps.ServerData //= require homepageVimeoFallback +/* eslint-enable spaced-comment */ diff --git a/app/assets/javascripts/homepageVimeoFallback.js b/app/assets/javascripts/homepageVimeoFallback.js index e4f5a67a..53c691eb 100644 --- a/app/assets/javascripts/homepageVimeoFallback.js +++ b/app/assets/javascripts/homepageVimeoFallback.js @@ -1,11 +1,11 @@ /* global $ */ -$(document).ready(function () { +$(document).ready(function() { if (window.location.pathname === '/') { $.ajax({ type: 'GET', url: 'https://player.vimeo.com', - error: function (e) { + error: function(e) { $('.homeVideo').hide() $('.homeVideo').replaceWith($('