Refine config mutability #10

New issue

Open

opened 2025-11-19 13:14:47 +00:00 by glenux · 0 comments

glenux commented

2025-11-19 13:14:47 +00:00

Owner

Description

Clarify and enforce stricter boundaries around the mutability of the global DocMachine::Config object after initial parsing, to prevent unintended side effects.

Expected outcome

Once argument parsing completes, DocMachine::Config should effectively be immutable for command Run classes; only the CLI parsing phase mutates it.

Current state

The shared config object is mutable and passed by reference, allowing subcommands to change properties after initialization, which may leak state between commands.

Technical details

Re-emphasize the config lifecycle in ADR 0005.
Consider using config.dup when handing off to Run classes.
Ensure command-specific config subclasses encapsulate their own mutations safely.

Additional info

Local task id: aa30c75.

## Description Clarify and enforce stricter boundaries around the mutability of the global `DocMachine::Config` object after initial parsing, to prevent unintended side effects. ## Expected outcome Once argument parsing completes, `DocMachine::Config` should effectively be immutable for command `Run` classes; only the CLI parsing phase mutates it. ## Current state The shared config object is mutable and passed by reference, allowing subcommands to change properties after initialization, which may leak state between commands. ## Technical details - Re-emphasize the config lifecycle in ADR 0005. - Consider using `config.dup` when handing off to `Run` classes. - Ensure command-specific config subclasses encapsulate their own mutations safely. ## Additional info Local task id: aa30c75.