glenux/docmachine-cli
glenux/docmachine-cli
1
0
Fork 0
Code Issues 16 Pull requests Projects 1 Releases Packages 1 Wiki Activity

8767d8c Use idiomatic parameter naming in AbstractContainerEngine #13

New issue
Open
opened 2025-11-19 13:19:47 +00:00 by glenux · 0 comments
glenux commented 2025-11-19 13:19:47 +00:00
Owner
Copy link

title: Use Idiomatic Parameter Naming in AbstractContainerEngine
description: Rename the docker_opts parameter in AbstractContainerEngine and its implementations to a more generic term to accurately reflect its abstract nature.
current_situation: The AbstractContainerEngine#run_container method and its concrete implementations (e.g., PodmanEngine) use docker_opts : Array(String), which is a Docker-specific name in an abstract context.
expected_outcome: The parameter name is changed to a more generic and abstract term, such as engine_opts or container_options, consistent with the abstraction.
technical_details:

  • Modify AbstractContainerEngine#run_container signature in src/container/abstract_container_engine.cr.
  • Update DockerEngine#run_container and PodmanEngine#run_container implementations (src/container/docker_engine.cr, src/container/podman_engine.cr).
  • Update any call sites, specifically in src/container/run.cr, to use the new parameter name.
--- title: Use Idiomatic Parameter Naming in `AbstractContainerEngine` description: Rename the `docker_opts` parameter in `AbstractContainerEngine` and its implementations to a more generic term to accurately reflect its abstract nature. current_situation: The `AbstractContainerEngine#run_container` method and its concrete implementations (e.g., `PodmanEngine`) use `docker_opts : Array(String)`, which is a Docker-specific name in an abstract context. expected_outcome: The parameter name is changed to a more generic and abstract term, such as `engine_opts` or `container_options`, consistent with the abstraction. technical_details: - Modify `AbstractContainerEngine#run_container` signature in `src/container/abstract_container_engine.cr`. - Update `DockerEngine#run_container` and `PodmanEngine#run_container` implementations (`src/container/docker_engine.cr`, `src/container/podman_engine.cr`). - Update any call sites, specifically in `src/container/run.cr`, to use the new parameter name. ---
glenux added this to the By Status project 2025-11-19 18:02:48 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
develop
feature/2025-03-18-add-support-for-podman
master
v1.1.0
v1.0.5
v1.0.4
v1.0.3
v1.0.2
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
By Status
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: glenux/docmachine-cli#13
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?