Review DocMachine::Config properties for public write access #14

New issue

Open

opened 2025-11-19 13:20:01 +00:00 by glenux · 0 comments

glenux commented

2025-11-19 13:20:01 +00:00

Owner

title

description

current_situation

expected_outcome

technical_details

Review `DocMachine::Config` Properties for Public Write Access

Re-evaluate `property` usage in `src/config.cr` and command-specific `Config` classes, replacing `property` with `getter` where values should be read-only after initialization.

All configuration settings in `DocMachine::Config` and its specialized versions use `property`, granting public read/write access to all settings.

Properties that are intended to be set only during initial configuration or argument parsing, and then remain constant during command execution, are changed from `property` to `getter`. Private setters can be used if internal modification is still needed.

Audit `src/config.cr` and all `[CommandName]::Config` files.

For each `property`, determine if it needs public write access throughout the application lifecycle.

If not, change `property` to `getter` and adjust setter access as needed.

--- title: Review `DocMachine::Config` Properties for Public Write Access description: Re-evaluate `property` usage in `src/config.cr` and command-specific `Config` classes, replacing `property` with `getter` where values should be read-only after initialization. current_situation: All configuration settings in `DocMachine::Config` and its specialized versions use `property`, granting public read/write access to all settings. expected_outcome: Properties that are intended to be set only during initial configuration or argument parsing, and then remain constant during command execution, are changed from `property` to `getter`. Private setters can be used if internal modification is still needed. technical_details: - Audit `src/config.cr` and all `[CommandName]::Config` files. - For each `property`, determine if it needs public write access throughout the application lifecycle. - If not, change `property` to `getter` and adjust setter access as needed. ---

glenux changed title from ~~6948935 Review DocMachine::Config properties for public write access~~ to Review DocMachine::Config properties for public write access

2025-11-19 13:27:06 +00:00

glenux added this to the By Status project

2025-11-19 18:02:48 +00:00