glenux-contrib/metamaps--metamaps
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix topic controller bugs

Browse source
This commit is contained in:
Devin Howard 2016-09-30 14:42:07 +08:00
parent 97c118a20b
commit 7156fab3e2
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/topics_controller.rb
View file

@ -88,7 +88,7 @@ class TopicsController < ApplicationController
topicsAlreadyHas = params[:network] ? params[:network].split(',').map(&:to_i) : [] topicsAlreadyHas = params[:network] ? params[:network].split(',').map(&:to_i) : []
alltopics = policy_scope(Topic.relatives(@topic.id)).to_a alltopics = policy_scope(Topic.relatives(@topic.id, current_user)).to_a
alltopics.delete_if { |topic| topic.metacode_id != params[:metacode].to_i } if params[:metacode].present? alltopics.delete_if { |topic| topic.metacode_id != params[:metacode].to_i } if params[:metacode].present?
alltopics.delete_if do |topic| alltopics.delete_if do |topic|
!topicsAlreadyHas.index(topic.id.to_s).nil? !topicsAlreadyHas.index(topic.id.to_s).nil?

10
app/models/topic.rb
View file

@ -36,19 +36,19 @@ class Topic < ApplicationRecord
validates_attachment_content_type :audio, content_type: /\Aaudio\/.*\Z/ validates_attachment_content_type :audio, content_type: /\Aaudio\/.*\Z/
def synapses def synapses
synapses1 + synapses2 synapses1.or(synapses2)
end end
def relatives def relatives
topics1 + topics2 topics1.or(topics2)
end end
scope :relatives, ->(topic_id = nil, user = nil) { scope :relatives, ->(topic_id = nil, user = nil) {
# should only see topics through *visible* synapses # should only see topics through *visible* synapses
# e.g. Topic A (commons) -> synapse (private) -> Topic B (commons) must be filtered out # e.g. Topic A (commons) -> synapse (private) -> Topic B (commons) must be filtered out
synapses = Pundit.policy_scope(user, Synapse.where(topic1_id: topic_id)).pluck(:topic2_id) topic_ids = Pundit.policy_scope(user, Synapse.where(topic1_id: topic_id)).pluck(:topic2_id)
synapses += Pundit.policy_scope(user, Synapse.where(topic2_id: topic_id)).pluck(:topic1_id) topic_ids += Pundit.policy_scope(user, Synapse.where(topic2_id: topic_id)).pluck(:topic1_id)
where(id: synapses.uniq) where(id: topic_ids.uniq)
} }
delegate :name, to: :user, prefix: true delegate :name, to: :user, prefix: true