Merge pull request #748 from metamaps/feature/api-json-404

return 404s for all unmatched api routes

app/controllers/api/v1/deprecated_controller.rb

@@ -2,11 +2,11 @@
 module Api
   module V1
     class DeprecatedController < ApplicationController
-      # rubocop:disable Style/MethodMissing
+      def deprecated
-      def method_missing
+        render json: {
-        render json: { error: '/api/v1 is deprecated! Please use /api/v2 instead.' }
+          error: '/api/v1 has been deprecated! Please use /api/v2 instead.'
+        }, status: :gone
       end
-      # rubocop:enable Style/MethodMissing
     end
   end
 end

app/controllers/api/v1/mappings_controller.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-module Api
-  module V1
-    class MappingsController < DeprecatedController
-    end
-  end
-end

app/controllers/api/v1/maps_controller.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-module Api
-  module V1
-    class MapsController < DeprecatedController
-    end
-  end
-end

app/controllers/api/v1/synapses_controller.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-module Api
-  module V1
-    class SynapsesController < DeprecatedController
-    end
-  end
-end

app/controllers/api/v1/tokens_controller.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-module Api
-  module V1
-    class TokensController < DeprecatedController
-    end
-  end
-end

app/controllers/api/v1/topics_controller.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-module Api
-  module V1
-    class TopicsController < DeprecatedController
-    end
-  end
-end

app/controllers/api/v2/restful_controller.rb

@@ -29,6 +29,11 @@ module Api
         head :no_content
       end
 
+      def catch_404
+        skip_authorization
+        render json: { error: '404 Not found' }, status: :not_found
+      end
+
       private
 
       def accessible_records

config/routes.rb

@@ -77,18 +77,13 @@ Metamaps::Application.routes.draw do
       resources :users, only: [:index, :show] do
         get :current, on: :collection
       end
+      match '*path', to: 'restful#catch_404', via: :all
     end
     namespace :v1, path: '/v1' do
-      # api v1 routes all lead to a deprecation error method
+      root to: 'deprecated#deprecated', via: :all
-      # see app/controllers/api/v1/deprecated_controller.rb
+      match '*path', to: 'deprecated#deprecated', via: :all
-      resources :maps, only: [:create, :show, :update, :destroy]
-      resources :synapses, only: [:create, :show, :update, :destroy]
-      resources :topics, only: [:create, :show, :update, :destroy]
-      resources :mappings, only: [:create, :show, :update, :destroy]
-      resources :tokens, only: [:create, :destroy] do
-        get :my_tokens, on: :collection
-      end
     end
+    match '*path', to: 'v2/restful#catch_404', via: :all
   end
 
   devise_for :users, skip: :sessions, controllers: {